Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coding standards error in settings.tugboat.php #287

Closed
mrdavidburns opened this issue Oct 20, 2023 · 2 comments · Fixed by #295
Closed

Fix coding standards error in settings.tugboat.php #287

mrdavidburns opened this issue Oct 20, 2023 · 2 comments · Fixed by #295

Comments

@mrdavidburns
Copy link
Member

This error started to appear when Renovate created a PR to upgrade to Drainpipe(-dev) v3.2.0

[test:phpcs] FILE: /var/www/html/web/sites/default/settings.tugboat.php
[test:phpcs] ----------------------------------------------------------------------
[test:phpcs] FOUND 1 ERROR AND 1 WARNING AFFECTING 1 LINE
[test:phpcs] ----------------------------------------------------------------------
[test:phpcs]  31 | WARNING | [ ] Line exceeds 80 characters; contains 83
[test:phpcs]     |         |     characters
[test:phpcs]  31 | ERROR   | [x] Perl-style comments are not allowed; use "//
[test:phpcs]     |         |     Comment" instead
[test:phpcs] ----------------------------------------------------------------------
[test:phpcs] PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
[test:phpcs] ----------------------------------------------------------------------
@mrdavidburns
Copy link
Member Author

@justafish I'm curious as to why we have scaffold/tugboat/settings.tugboat.php.twig while we have scaffold/pantheon/settings.pantheon.php.

Should we rename settings.tugboat.php.twig to settings.tugboat.php and address the syntax error in this file?

@justafish
Copy link
Member

@mrdavidburns the settings file generated for Tugboat is a bit more complex - it takes it's PHP and database version from DDEV, whereas the pantheon settings is a fixed file. It'd be nice in future if this would take values from DDEV too and populate pantheon.yml 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants