-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JSON check #4
Comments
The test "Parse" is used to perform this exact test. JsonBenchmark/src/benchmark/PerformanceChecker.cpp Lines 152 to 170 in debd1ce
You will notice that nothing is done with the result of the parse. In your case we simply need to modify the corresponding test implementation: JsonBenchmark/src/ThirdParty/nlohmannTest.cpp Lines 69 to 79 in debd1ce
If you feel like providing a pull request with this change I would be be happy to merge. |
The nlohmann/json has a function
accept
which just checks whether an input is valid JSON. As no internal structure is built, this check is much faster than parsing. Maybe other libraries have this as well, and benchmarking it could be helpful.The text was updated successfully, but these errors were encountered: