Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependencies should be devDependencies #24

Open
dbrenot-pelmorex opened this issue Jan 26, 2023 · 1 comment · May be fixed by #26
Open

Dependencies should be devDependencies #24

dbrenot-pelmorex opened this issue Jan 26, 2023 · 1 comment · May be fixed by #26

Comments

@dbrenot-pelmorex
Copy link

When installing this package from npm, dependencies will be installed by anything that depends on this library. This means that eslint will be installed in my library and will stick around in production even though it's only needed when developing this library.

Please rename dependencies to devDependencies so that downstream users of this library don't have to install the dev dependencies and their transitive dependencies.
@dbrenot-pelmorex dbrenot-pelmorex linked a pull request Jan 26, 2023 that will close this issue
Open
@indrasen715
Copy link
Collaborator

Hi @dbrenot-pelmprex ,

Thanks for bringing this to our notice, and we appreciate your valuable feedback on this.

I will review this feedback with the team and keep you posted on the progress.

Regards
Indrasen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Renamed dependencies to devDependencies dbrenot-pelmorex/node-js-sdk
2 participants
@indrasen715 @dbrenot-pelmorex