Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in QRes command in documentations #1484

Closed
3 tasks done
ahmadalli opened this issue Jul 31, 2023 · 4 comments · Fixed by #1334
Closed
3 tasks done

Typo in QRes command in documentations #1484

ahmadalli opened this issue Jul 31, 2023 · 4 comments · Fixed by #1334
Labels
documentation Improvements or additions to documentation fixed This issue has been fixed and will be available in the next release.

Comments

@ahmadalli
Copy link
Contributor

ahmadalli commented Jul 31, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Is your issue described in the documentation?

  • I have read the documentation

Is your issue present in the nightly release?

  • This issue is present in the nightly release

Describe the Bug

The Do Command for windows in the docs uses SUNSHINE_CLIENT_WIDTH instead of SUNSHINE_CLIENT_HEIGHT (this was overlooked on #1430).

Expected Behavior

The command for Windows should be cmd /C FullPath\qres.exe /x:%SUNSHINE_CLIENT_WIDTH% /y:%SUNSHINE_CLIENT_HEIGHT% /r:%SUNSHINE_CLIENT_FPS%

Additional Context

No response

Host Operating System

other, n/a

Operating System Version

n/a

Architecture

64 bit

Sunshine commit or version

0.20.0

Package

Windows - installer

GPU Type

Nvidia

GPU Model

n/a

GPU Driver/Mesa Version

n/a

Capture Method (Linux Only)

No response

Config

n/a

Apps

No response

Relevant log output

[2023:07:31:09:03:37]: Info: Executing Do Cmd: [cmd /C D:\Programs\qres\QRes.exe /x:%SUNSHINE_CLIENT_WIDTH% /y:%SUNSHINE_CLIENT_WIDTH% /r:%SUNSHINE_CLIENT_FPS%]
[2023:07:31:09:03:37]: Info: cmd /C D:\Programs\qres\QRes.exe /x:%SUNSHINE_CLIENT_WIDTH% /y:%SUNSHINE_CLIENT_WIDTH% /r:%SUNSHINE_CLIENT_FPS% running with PID 27568
@ahmadalli ahmadalli changed the title Typo in QRes command in docs and more clarification Typo in QRes command Jul 31, 2023
@ahmadalli ahmadalli changed the title Typo in QRes command Typo in QRes command in documentations Jul 31, 2023
@ReenigneArcher
Copy link
Member

Why not just make a PR fixing it?

@ahmadalli
Copy link
Contributor Author

I was going to do that but got distracted by other stuff. I'll do that

@ahmadalli ahmadalli mentioned this issue Jul 31, 2023
11 tasks
@ReenigneArcher
Copy link
Member

Please leave open, until we merge this into master

@ReenigneArcher ReenigneArcher added documentation Improvements or additions to documentation fixed This issue has been fixed and will be available in the next release. labels Jul 31, 2023
@LizardByte-bot
Copy link
Member

This issue has been fixed and will be available in the next release.

@ReenigneArcher ReenigneArcher mentioned this issue Sep 13, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation fixed This issue has been fixed and will be available in the next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants