Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The installer won't use system proxy to download ViGEmBus #1116

Closed
3 tasks done
lns103 opened this issue Mar 31, 2023 · 5 comments · Fixed by #1334
Closed
3 tasks done

The installer won't use system proxy to download ViGEmBus #1116

lns103 opened this issue Mar 31, 2023 · 5 comments · Fixed by #1334
Labels
fixed This issue has been fixed and will be available in the next release.

Comments

@lns103
Copy link
Contributor

lns103 commented Mar 31, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Is your issue described in the documentation?

  • I have read the documentation

Is your issue present in the nightly release?

  • This issue is present in the nightly release

Describe the Bug

In China, the speed of accessing GitHub by most ISPs is very slow and may facing blocking. The installation process can get stuck while downloading ViGEmBus. Most people use proxy to speed up their access to GitHub. If it is possible to download through the system proxy, it could significantly improve the installation experience for many Chinese users.
For my ISP, the speed of directly download from GitHub is about 20kb/s.😥
image

Expected Behavior

Use system proxy to download ViGEmBus.

Additional Context

No response

Host Operating System

Windows

Operating System Version

11

Architecture

64 bit

Sunshine commit or version

0.19.1

Package

Windows - installer

GPU Type

Nvidia

GPU Model

RTX 2060

GPU Driver/Mesa Version

528.02

Capture Method (Linux Only)

No response

Config

not important

Apps

No response

Relevant log output

no log
@ReenigneArcher
Copy link
Member

We're just using standard curl in a bat file to download it. As far as I know it doesn't support using the system proxy. If you want support for that you'll need to talk to the people of curl.

Alternatively, just download and install it yourself.

@ReenigneArcher ReenigneArcher closed this as not planned Won't fix, can't repro, duplicate, stale Mar 31, 2023
@lns103
Copy link
Contributor Author

lns103 commented Mar 31, 2023

We're just using standard curl in a bat file to download it. As far as I know it doesn't support using the system proxy. If you want support for that you'll need to talk to the people of curl.

Alternatively, just download and install it yourself.

I changed curl -s -L -o "%temp_dir%\vigembus.exe" %browser_download_url%
to powershell -Command "(New-Object Net.WebClient).DownloadFile('%browser_download_url%', '%temp_dir%\vigembus.exe')"
in /src_assets/windows/misc/vigembus/install-vigembus.bat,
and it's working for me.
Could you please modify this?🙏

@ReenigneArcher
Copy link
Member

You can submit a PR and we will review it.

@ReenigneArcher
Copy link
Member

Instead of using PowerShell, we should find a way to get the system proxy using batch scripting. Perhaps netsh winhttp show proxy?

Then set the appropriate proxy variables.

Or set the proxy in the _curlrc file. https://stackoverflow.com/a/35815181/11214013

@lns103 lns103 closed this as completed Jul 12, 2023
@ReenigneArcher ReenigneArcher added the fixed This issue has been fixed and will be available in the next release. label Jul 12, 2023
@LizardByte-bot
Copy link
Member

This issue has been fixed and will be available in the next release.

@ReenigneArcher ReenigneArcher mentioned this issue Sep 13, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed This issue has been fixed and will be available in the next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants