Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge python-app.yml and tests.yml? #33

Open
yohanchatelain opened this issue Oct 28, 2022 · 2 comments
Open

Merge python-app.yml and tests.yml? #33

yohanchatelain opened this issue Oct 28, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@yohanchatelain
Copy link
Collaborator

We could merge those files and add cron schedule to python-app.yml to maintain one instead of two files. @mathdugre

@yohanchatelain yohanchatelain added the enhancement New feature or request label Oct 28, 2022
@mathdugre
Copy link
Collaborator

Yes, I totally agree that we can merge those.

Eventually, we might want to separate the linting in a different action to only run on push and include more linting via pre-commit. Similar to livingpark-utils' linting. What do you think @yohanchatelain ?

@yohanchatelain
Copy link
Collaborator Author

Yes it is a good practice 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants