Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChunkedDataset AppendDataset null check #268

Open
gaschd opened this issue Jan 4, 2023 · 0 comments
Open

ChunkedDataset AppendDataset null check #268

gaschd opened this issue Jan 4, 2023 · 0 comments

Comments

@gaschd
Copy link

gaschd commented Jan 4, 2023

I tried to create a workaround for enabling filters in #107 by creating a dataset with HDF5.PInvoke myself and then using the constructor of a ChunkedDataset to use filtered dataset by providing the same groupId and Datasetname.

FirstDataset method does not work since the Datasetname is already in use.
AppendDataset fails since _oldDims is null and size / offset variable calculations depend on it.

In order to be able to use this workaround, either AppendDataset needs to accept _oldDims as null on the first run (by trying to read the current dimensions) or an "OpenIfExists(groupId, datasetname)" method should be introduced to initialize from an already existing dataset. This would also benefit modifing existing hdf5 files with chunked datasets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant