Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightning-bolts is referring to LightningLoggerBase which has been removed from pytorch-lightning #983

Closed
deepio-oc opened this issue Feb 26, 2023 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@deepio-oc
Copy link

🐛 Bug

Rename from LightningLoggerBase to Logger was done here:

Lightning-AI/pytorch-lightning#11971

To Reproduce

from pl_bolts.datamodules import MNISTDataModule

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/conda/lib/python3.10/site-packages/pl_bolts/__init__.py", line 11, in <module>
    from pl_bolts import (  # noqa: E402
  File "/usr/conda/lib/python3.10/site-packages/pl_bolts/callbacks/__init__.py", line 3, in <module>
    from pl_bolts.callbacks.data_monitor import ModuleDataMonitor, TrainingDataMonitor
  File "/usr/conda/lib/python3.10/site-packages/pl_bolts/callbacks/data_monitor.py", line 6, in <module>
    from pytorch_lightning.loggers import LightningLoggerBase, TensorBoardLogger, WandbLogger
ImportError: cannot import name 'LightningLoggerBase' from 'pytorch_lightning.loggers' (/usr/conda/lib/python3.10/site-packages/pytorch_lightning/loggers/__init__.py)

Code sample

from pl_bolts.datamodules import MNISTDataModule

Expected behavior

MNISTDataModule should be imported without error

Environment

  • PyTorch Version: pytorch-lightning==1.9.3
  • OS: linux
  • How you installed PyTorch: pytorch-lightning==1.9.3
  • Python version: 3.10
@deepio-oc deepio-oc added the help wanted Extra attention is needed label Feb 26, 2023
@deepio-oc
Copy link
Author

deepio-oc commented Feb 26, 2023

duplicate of #962 and #972

@deepio-oc deepio-oc changed the title lightning-bolts is referring to LightningLoggerBase from pytorch-lightning but this has been renamed a year ago lightning-bolts is referring to LightningLoggerBase which has been removed from pytorch-lightning Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant