Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LightningLoggerBase is not found from Lightning 1.9 #963

Closed
senarvi opened this issue Jan 19, 2023 · 1 comment
Closed

LightningLoggerBase is not found from Lightning 1.9 #963

senarvi opened this issue Jan 19, 2023 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@senarvi
Copy link
Contributor

senarvi commented Jan 19, 2023

🐛 Bug

Since Lightning 1.9, LightningLoggerBase class cannot be found anymore. DataMonitor callback tries to import it, resulting in an ImportError.

To Reproduce

Steps to reproduce the behavior:

  1. Install lightning==1.9.0.
  2. Import pl_bolts in a Python interpreter.
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File ".../pl_bolts/__init__.py", line 11, in <module>
    from pl_bolts import (  # noqa: E402
  File ".../pl_bolts/callbacks/__init__.py", line 3, in <module>
    from pl_bolts.callbacks.data_monitor import ModuleDataMonitor, TrainingDataMonitor
  File ".../pl_bolts/callbacks/data_monitor.py", line 6, in <module>
    from pytorch_lightning.loggers import LightningLoggerBase, TensorBoardLogger, WandbLogger
ImportError: cannot import name 'LightningLoggerBase' from 'pytorch_lightning.loggers' (/users/seenarvi/git/pytorch-lightning/src/pytorch_lightning/loggers/__init__.py)

Environment

  • PyTorch Version (e.g., 1.0): 1.13
  • OS (e.g., Linux): Linux
  • How you installed PyTorch (conda, pip, source): pip
  • Python version: 3.9.7

Additional context

Looks like it should be renamed to Logger.

@senarvi senarvi added the help wanted Extra attention is needed label Jan 19, 2023
@senarvi
Copy link
Contributor Author

senarvi commented Jan 19, 2023

This is a duplicate of #962 . Seems like someone else submitted a bug report while I was writing this. :)

@senarvi senarvi closed this as completed Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant