Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the Rich Progress Bar #9547

Closed
SeanNaren opened this issue Sep 15, 2021 · 1 comment · Fixed by #9559
Closed

Improve the Rich Progress Bar #9547

SeanNaren opened this issue Sep 15, 2021 · 1 comment · Fixed by #9559
Assignees
Labels
feature Is an improvement or enhancement

Comments

@SeanNaren
Copy link
Contributor

🚀 Feature

Motivation

@kaushikb11 did a great job with introducing the Rich Progress Bar, however I think we're away from what's pleasing + interesting additions!

Regarding the colour choices, we should allow some form of modifications via config dict or the callback's __init__

At the very least, I say we go from this:
Screenshot 2021-09-15 at 22 19 03

to something more uniform like this:
Screenshot 2021-09-15 at 22 16 43

In terms of additional benefits, I think we can explore how easy it would be to allow users to add their own rich components. For example, a GPURichProgressBar could add an element to log the GPU utilization into the progress bar.

@SeanNaren SeanNaren added the feature Is an improvement or enhancement label Sep 15, 2021
@SeanNaren SeanNaren self-assigned this Sep 15, 2021
@ananthsub
Copy link
Contributor

ananthsub commented Sep 16, 2021

For example, a GPURichProgressBar could add an element to log the GPU utilization into the progress bar.

This could be a cool collaboration with #9032 - if the accelerator returns the device stats, the rich progress bar could visualize this w/o needing to configure a separate device stats monitor (unless users want to log these stats to some other destination too) @daniellepintz

the progress bar being both a logger (logging + visualizing data) and a callback (updating state based on the loop) merits exploration as to whether there's some higher-level composition that should be offered here. this intersection seems to be heating up further with wandb and mlflow each becoming more featured in what were previously silo-ed interfaces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants