-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename ProgressBar callback to TQDMProgressBar #9302
Comments
Could someone please add the |
This is a breaking change and would have to go through depreciation cycle. |
If we do the following, it wouldn't be breaking, right? class TQDMProgressBar(ProgressBarBase):
...
# points to the default implementation
ProgressBar = TQDMProgressBar |
@carmocca yeah makes sense to me! looks like @kaushikb11 's PR fixes this |
This issue has been automatically marked as stale because it hasn't had any recent activity. This issue will be closed in 7 days if no further activity occurs. Thank you for your contributions, Pytorch Lightning Team! |
I'd like to take on this, would you please assing this to me? @daniellepintz |
Thanks @InCogNiTo124 ! I think @kaushikb11 already has a PR out for this #9229 but hasnt merged it yet. @kaushikb11 what is the status of the PR? |
Proposed refactoring or deprecation
Rename ProgressBar callback to TQDMProgressBar (https://github.com/tqdm/tqdm)
https://github.com/daniellepintz/pytorch-lightning/blob/a49690dfa3502508c8765e6bb46ded17e561af8e/pytorch_lightning/callbacks/progress/progress.py#L55-L55
Motivation
After we added the RichProgressBar in #8929, it makes sense to rename ProgressBar to something more specific.
Pitch
Update all references of ProgressBar to TQDMProgressBar
Additional context
If you enjoy Lightning, check out our other projects! ⚡
Metrics: Machine learning metrics for distributed, scalable PyTorch applications.
Flash: The fastest way to get a Lightning baseline! A collection of tasks for fast prototyping, baselining, finetuning and solving problems with deep learning
Bolts: Pretrained SOTA Deep Learning models, callbacks and more for research and production with PyTorch Lightning and PyTorch
Lightning Transformers: Flexible interface for high performance research using SOTA Transformers leveraging Pytorch Lightning, Transformers, and Hydra.
The text was updated successfully, but these errors were encountered: