Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename callbacks/base.py to callbacks/callback.py #11973

Closed
daniellepintz opened this issue Feb 18, 2022 · 5 comments · Fixed by #13031
Closed

Rename callbacks/base.py to callbacks/callback.py #11973

daniellepintz opened this issue Feb 18, 2022 · 5 comments · Fixed by #13031
Assignees
Labels
callback good first issue Good for newcomers help wanted Open to be worked on refactor

Comments

@daniellepintz
Copy link
Contributor

daniellepintz commented Feb 18, 2022

Proposed refactor

Rename callbacks/base.py to callbacks/callback.py

Motivation

For consistency, let's conform to the standard of our other main files, like accelerators/accelerator.py and strategies/strategy.py.

Part of #11908

cc @Borda @justusschock @awaelchli @rohitgr7 @ananthsub @daniellepintz

@ananthsub ananthsub added the good first issue Good for newcomers label Feb 18, 2022
@PushanAgrawal
Copy link

Hello, can I make a pull request for this issue?

@daniellepintz
Copy link
Contributor Author

Yes! Assigning you :)

@shantam-8
Copy link
Contributor

Hello @daniellepintz, is this issue still open? If yes, should I make a new PR?

@akihironitta
Copy link
Contributor

Hi @PushanAgrawal! Thank you for working on this in #11996! Would you like to continue the linked PR or let another contributor work on this issue instead?

Hi @shantam-8! Thanks for your interest in contributing! Let's wait maybe for a few days to hear if @PushanAgrawal still wishes to continue to work on it :] In the meantime, you could pick one of the issues labeled "good first issue" or "help wanted"! (#12521 has a lot of TODO items and definitely needs help from the community!)

@akihironitta
Copy link
Contributor

@shantam-8 Would you be interested in submitting a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
callback good first issue Good for newcomers help wanted Open to be worked on refactor
Projects
None yet
5 participants