Logging in validation step that is the same as training step

[RafailFridman]

Hi, my validation step is the same as the training step:

def validation_step(self, batch, batch_idx):
    return self.training_step(batch, batch_idx)

In training step I call logging of some metrics like this:

self.log("train/combined_loss", loss, prog_bar=False, on_epoch=True, on_step=False)

But what I want to do is replace "train/combined_loss" with something like f"{self.current_stage}/combined_loss"
Is it possible to achieve somehow?

[RafailFridman]

I'm now doing like this:

def training_step(self, batch, batch_idx):
    logging_prefix = "train" if self.trainer.training else "val"
    ...
    self.log(f"{logging_prefix}/combined_loss", loss, prog_bar=False, on_epoch=True, on_step=False)

But maybe there is a better way?

[rohitgr7]

this looks ok.. you can also use self.log(f"{self.trainer.state.stage}/combined_loss" to avoid that one line of code.

Also here:

def validation_step(self, batch, batch_idx):
    return self.training_step(batch, batch_idx)

I'd suggest creating another custom function which is called within both training_step and validation_step.