Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typing: classif #335

Merged
merged 14 commits into from
Jun 30, 2021
Merged

typing: classif #335

merged 14 commits into from
Jun 30, 2021

Conversation

Borda
Copy link
Member

@Borda Borda commented Jun 30, 2021

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes # (issue).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the refactoring refactoring and code health label Jun 30, 2021
@codecov
Copy link

codecov bot commented Jun 30, 2021

Codecov Report

Merging #335 (39d8abd) into master (877244e) will decrease coverage by 0.17%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #335      +/-   ##
==========================================
- Coverage   96.55%   96.37%   -0.18%     
==========================================
  Files         111      111              
  Lines        3569     3586      +17     
==========================================
+ Hits         3446     3456      +10     
- Misses        123      130       +7     
Flag Coverage Δ
Linux 75.98% <84.12%> (+0.05%) ⬆️
Windows 75.98% <84.12%> (+0.05%) ⬆️
cpu 96.31% <88.88%> (-0.18%) ⬇️
gpu 96.29% <88.88%> (-0.18%) ⬇️
macOS 96.31% <88.88%> (-0.18%) ⬇️
pytest 96.37% <88.88%> (-0.18%) ⬇️
python3.6 95.45% <87.30%> (-0.18%) ⬇️
python3.8 96.31% <88.88%> (-0.18%) ⬇️
python3.9 96.20% <88.88%> (-0.18%) ⬇️
torch1.3.1 95.45% <87.30%> (-0.18%) ⬇️
torch1.4.0 95.53% <87.30%> (-0.18%) ⬇️
torch1.9.0 96.20% <88.88%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
torchmetrics/classification/average_precision.py 96.66% <66.66%> (-3.34%) ⬇️
...chmetrics/classification/precision_recall_curve.py 96.66% <66.66%> (-3.34%) ⬇️
torchmetrics/classification/roc.py 96.55% <66.66%> (-3.45%) ⬇️
torchmetrics/classification/accuracy.py 92.98% <77.77%> (-3.18%) ⬇️
torchmetrics/classification/auroc.py 90.90% <83.33%> (-1.78%) ⬇️
torchmetrics/classification/stat_scores.py 98.36% <90.90%> (-1.64%) ⬇️
torchmetrics/classification/auc.py 100.00% <100.00%> (ø)
...hmetrics/classification/binned_precision_recall.py 100.00% <100.00%> (ø)
torchmetrics/classification/cohen_kappa.py 95.65% <100.00%> (ø)
torchmetrics/classification/confusion_matrix.py 96.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 877244e...39d8abd. Read the comment docs.

@pep8speaks
Copy link

pep8speaks commented Jun 30, 2021

Hello @Borda! Thanks for updating this PR.

Line 186:13: E731 do not assign a lambda expression, use a def

Comment last updated at 2021-06-30 13:33:11 UTC

@Borda Borda marked this pull request as ready for review June 30, 2021 10:51
@Borda Borda changed the title typing classif typing: classif Jun 30, 2021
@mergify mergify bot removed the has conflicts label Jun 30, 2021
@Borda Borda self-assigned this Jun 30, 2021
@Borda Borda added the enhancement New feature or request label Jun 30, 2021
torchmetrics/classification/accuracy.py Show resolved Hide resolved
torchmetrics/classification/accuracy.py Outdated Show resolved Hide resolved
torchmetrics/classification/accuracy.py Show resolved Hide resolved
torchmetrics/classification/accuracy.py Show resolved Hide resolved
torchmetrics/classification/auroc.py Show resolved Hide resolved
Borda and others added 2 commits June 30, 2021 15:14
@Borda Borda requested a review from justusschock June 30, 2021 13:28
@mergify mergify bot removed the has conflicts label Jun 30, 2021
@Borda Borda requested a review from maximsch2 June 30, 2021 14:03
@Borda Borda merged commit eaf85cf into master Jun 30, 2021
@Borda Borda deleted the typing/clf branch June 30, 2021 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactoring refactoring and code health
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants