-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ignore_index
option to exact_match
metric
#1540
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ignore_index
option to exact_match
metric
Borda
approved these changes
Feb 22, 2023
SkafteNicki
requested changes
Feb 22, 2023
SkafteNicki
approved these changes
Feb 23, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1540 +/- ##
========================================
- Coverage 87% 51% -36%
========================================
Files 216 216
Lines 11331 11332 +1
========================================
- Hits 9842 5752 -4090
- Misses 1489 5580 +4091 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 1508
This fix sets
preds
to equal theignore_index
in the same indices thattarget == ignore_index
such that if all other elements inpreds
except the ones at indices wheretarget == ignore_index
are identical this constitutes an exact match.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
The following test checks that it functions correctly: