Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move scripts inside the package #982

Closed
carmocca opened this issue Mar 1, 2024 · 2 comments
Closed

Move scripts inside the package #982

carmocca opened this issue Mar 1, 2024 · 2 comments
Assignees
@carmocca
Milestone
Configurability

Comments

@carmocca
Copy link
Contributor

carmocca commented Mar 1, 2024

So that it can be called with python -m litgpt.pretrain ...
@carmocca carmocca added this to the Configurability milestone Mar 1, 2024
@carmocca carmocca mentioned this issue Mar 4, 2024
Merged
@awaelchli
Copy link
Contributor

To avoid cluttering the lit_gpt folder, and to avoid name clashes (like lora.py (finetuning) and lora.py (model definition)), we should probably move either the core files into a subfolder core, or move the "training scripts" into a subfolder.

@carmocca carmocca self-assigned this Mar 6, 2024
@carmocca
Copy link
Contributor Author

carmocca commented Mar 6, 2024

Closing this in favor of #996 since they should happen together.

@carmocca carmocca closed this as not planned Won't fix, can't repro, duplicate, stale Mar 6, 2024
@carmocca carmocca mentioned this issue Mar 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carmocca carmocca

Labels
None yet
Projects
None yet
Milestone
Configurability
Development

No branches or pull requests
2 participants
@awaelchli @carmocca