Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI arguments are not properly forwarded to subparsers #12790

Closed
carmocca opened this issue Apr 18, 2022 · 0 comments · Fixed by #15138
Closed

CLI arguments are not properly forwarded to subparsers #12790

carmocca opened this issue Apr 18, 2022 · 0 comments · Fixed by #15138
Assignees
@carmocca
Labels
bug Something isn't working lightningcli pl.cli.LightningCLI
Milestone
v1.8

Comments

@carmocca
Copy link
Contributor

carmocca commented Apr 18, 2022 •
edited by github-actions bot
Loading

🐛 Bug

To Reproduce

cli = LightningCLI(..., env_parse=True, description="foobar")

These do not get enabled

cc @carmocca @mauvilsa
@carmocca carmocca added bug Something isn't working lightningcli pl.cli.LightningCLI labels Apr 18, 2022
@carmocca carmocca added this to the 1.6.x milestone Apr 18, 2022
@carmocca carmocca self-assigned this Apr 18, 2022
@carmocca carmocca moved this to Todo in Frameworks Planning May 9, 2022
@carmocca carmocca modified the milestones: pl:1.6.x, pl:1.7.x Jul 28, 2022
@carmocca carmocca modified the milestones: pl:1.7.x, v1.8.x Oct 13, 2022
@mauvilsa mauvilsa mentioned this issue Oct 14, 2022
Merged
11 tasks
@carmocca carmocca modified the milestones: v1.8.x, v1.8 Oct 21, 2022
Repository owner moved this from Todo to Done in Frameworks Planning Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carmocca carmocca

Labels
bug Something isn't working lightningcli pl.cli.LightningCLI
Projects
No open projects
Frameworks Planning
Status: Done
Milestone
v1.8
Development

Successfully merging a pull request may close this issue.

Fix LightningCLI parse_env and description in subcommands
1 participant
@carmocca