-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor pl_bolts.callbacks
#477
Merged
Borda
merged 6 commits into
Lightning-Universe:master
from
akihironitta:refactor/callbacks
Jan 2, 2021
Merged
Refactor pl_bolts.callbacks
#477
Borda
merged 6 commits into
Lightning-Universe:master
from
akihironitta:refactor/callbacks
Jan 2, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #477 +/- ##
==========================================
+ Coverage 80.52% 80.63% +0.11%
==========================================
Files 103 102 -1
Lines 5710 5769 +59
==========================================
+ Hits 4598 4652 +54
- Misses 1112 1117 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
akihironitta
changed the title
Refactor callbacks [wip]
Refactor Dec 24, 2020
pl_bolts.callbacks
[wip]
8 tasks
akihironitta
changed the title
Refactor
Refactor Dec 24, 2020
pl_bolts.callbacks
[wip]pl_bolts.callbacks
8 tasks
Borda
approved these changes
Jan 2, 2021
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Follow-up PR of #338.
__all__
inpl_bolts/callbacks/__init__.py
_WANDB_AVAILABLE
inpl_bolts/utils/__init__.py
_*_AVAILABLE
variables defined in Refactorpl_bolts.datamodules
andpl_bolts.datasets
#338 for optional package importspragma: no cover
instead ofpragma: no-cover
If the above changes are too many in a single PR, I'll split this PR into some.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃