Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jupyter cells need a "i'm calculating" indicator #84

Closed
moorepants opened this issue Nov 4, 2019 · 8 comments
Closed

Jupyter cells need a "i'm calculating" indicator #84

moorepants opened this issue Nov 4, 2019 · 8 comments

Comments

@moorepants
Copy link
Member

When a user executes a cell it may take some time to complete or even never complete. We need a way for them to know that the calculation is occuring. And thus a "stop" button is likely needed too.

@moorepants
Copy link
Member Author

sphinx-thebe implements a very clear indicator:
image

@moorepants
Copy link
Member Author

Can we copy this indicator from sphinx-thebe (or something similar) and implement in our ckeditor plugin? That would solve this.

@sandertyu
Copy link
Contributor

I think this is solved by the ckeditor binder plugin status field changes?

@moorepants
Copy link
Member Author

One issue is giving more feedback on the initial connection to binder, which I think we now have. But the second issue is getting feedback when you run an individual cell. We should clarify more these two needs. I think for the second one we may need improvements to thebe.

@moorepants
Copy link
Member Author

When running a cell in a Jupyterlab notebook there is this indicator:

image

That circle turns grey when the cell is calculating. There is likely a way to get thebe to tap into that signal.

@moorepants moorepants added the good first issue Good for newcomers label Jan 8, 2021
@TimStewartJ
Copy link
Member

Is this solved by jupyter-book/thebe#424? It sounds like this is what we were looking for.

@moorepants
Copy link
Member Author

Yes, we just need to make a new thebe release.

@moorepants
Copy link
Member Author

A spinner is now default in thebe 0.8.0. See jupyter-book/thebe#424, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants