Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lemmy-ui layout on tablets and small wide screens. #799

Closed
xximj opened this issue Sep 26, 2022 · 3 comments · Fixed by #813
Closed

Fix lemmy-ui layout on tablets and small wide screens. #799

xximj opened this issue Sep 26, 2022 · 3 comments · Fixed by #813
Labels
bug Something isn't working

Comments

@xximj
Copy link
Contributor

xximj commented Sep 26, 2022

Issue Summary

Lemmy-ui on 12 inch screens or less is using same desktop layout which is making content stuffed especially in the sidebar.
Giving a wider space for lemmy-ui layout on tablets and small wide screens, can be better for sidebar content.
This change will not affect lemmy-ui layout on desktop or mobile.

container :

Screen Shot 2022-09-26 at 16 59 41

container-lg :

Screen Shot 2022-09-26 at 17 01 02

Steps to Fix

1. Replace All Bootstrap container divs with container-lg across all lemmy-ui views

@xximj xximj added the bug Something isn't working label Sep 26, 2022
@dessalines
Copy link
Member

Hrm... sounds like a good idea. Could you do a PR for this? Grep for all the cases of "container"

@xximj
Copy link
Contributor Author

xximj commented Sep 27, 2022

I'd like to but, I made many unnecessary edits on my fork and not really sure how to do a PR for specific parts of the code.
It may take some time until I figure out how to do it but I'd be happy to help.

@Nutomic
Copy link
Member

Nutomic commented Sep 27, 2022

Easiest option is probably to clone the repo a second time into another folder, and then copy your changes over. There is also git commit --interactive but its more complicated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants