Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for Spoiler Text in Markdown in addition to the collapsed sections currently supported #2115

Closed
3 tasks done
DraconicNEO opened this issue Sep 4, 2023 · 4 comments
Closed
3 tasks done
Labels
enhancement New feature or request

Comments

@DraconicNEO
Copy link

DraconicNEO commented Sep 4, 2023

Requirements

  • This is a feature request and not a bug report. Otherwise, please create a new bug report instead.
  • Please check to see if this request (or a similar one) already exists.
  • It's a single feature. Please don't request multiple features in one issue.

Describe the feature you'd like

I think it would be good if Lemmy-ui supported spoiler text in addition to the spoiler tags since collapsed spoiler sections don't work well if you only want to censor specific words, names, or phrases.

I think a good solution would be to add a simple spoiler text MD implementation such as >!spoiler text!< where the spoiler portion is began by typing >! before the spoilered section and terminated by typing !< at the end of it and unlike the current spoiler implementation which uses a drop-down to reveal it, this one would just be blocks over the text that would reveal the text when clicked on and since the syntax is simpler it can be used to block out words or phrases without disrupting the structure of a sentence.

@DraconicNEO DraconicNEO added the enhancement New feature or request label Sep 4, 2023
@DraconicNEO DraconicNEO changed the title Allow for standard Markdown Spoiler Text Allow for Spoiler Text in Markdown in addition to the collapsed sections currently supported Sep 4, 2023
@biosfood
Copy link
Contributor

This has been implemented in #2126

@DraconicNEO
Copy link
Author

This has been implemented in #2126

Awesome, does it use the same >!spoiler text!< implementation or is it initiated using different characters?

Also if you don't mind could I see a preview of what it looks like?

@foresto
Copy link

foresto commented Oct 6, 2023

This has been implemented in #2126

If I understand the issue descriptions correctly, then no, I don't think this has been implemented. That PR is about supporting markdown styling within spoiler block headings. This issue is about implementing an inline spoiler syntax.

This issue may be a duplicate of #687.

@DraconicNEO
Copy link
Author

This has been implemented in #2126

If I understand the issue descriptions correctly, then no, I don't think this has been implemented. That PR is about supporting markdown styling within spoiler block headings. This issue is about implementing an inline spoiler syntax.

Well I do know that some people have features as part of unrelated pull requests so I wasn't sure if he did that or if he's just confused and thought that I meant something different.

This issue may be a duplicate of #687.

I believe it is, that is exactly what I'm describing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants