Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search on communities page searches all content #1808

Closed
4 tasks done
RayBB opened this issue Jul 4, 2023 · 3 comments · Fixed by #2108
Closed
4 tasks done

Search on communities page searches all content #1808

RayBB opened this issue Jul 4, 2023 · 3 comments · Fixed by #2108
Labels
bug Something isn't working

Comments

@RayBB
Copy link
Contributor

RayBB commented Jul 4, 2023

Requirements

  • This is a bug report, and if not, please post to https://lemmy.ml/c/lemmy_support instead.
  • Please check to see if this issue already exists.
  • It's a single bug. Do not report multiple bugs in one issue.
  • It's a frontend issue, not a backend issue; Otherwise please create an issue on the backend repo instead.

Summary

Search bar on communities page doesn't search communities it searches all content.

Video:

out.mp4

Steps to Reproduce

  1. Go to https://lemmy.ml/communities
  2. Type "tech" in the search bar
  3. Click "Search"
  4. You still be redirected to https://lemmy.ml/search?q=tech
  5. The results show search results for "all" instead of just communities
  6. It should redirect you to https://lemmy.ml/search?q=tech&type=Communities

Technical Details

FF on latest Mac OS

Lemmy Instance Version

BE: 0.18.0

Lemmy Instance URL

https://lemmy.ml

@RayBB RayBB added the bug Something isn't working label Jul 4, 2023
@SleeplessOne1917
Copy link
Member

@dessalines @jsit @alectrocute Do you think the user should even be redirected away from the communities page for this?

@jsit
Copy link
Contributor

jsit commented Jul 4, 2023

  1. Voyager already adds &type=Communities when I search from the communities page. Would like others to confirm.

  2. Do you think the user should even be redirected away from the communities page for this?

    I don't think the Communities page is really equipped to display search results, so this redirect makes sense to me for now

@SleeplessOne1917
Copy link
Member

I don't think the Communities page is really equipped to display search results, so this redirect makes sense to me for now

Gotcha. TBF, the current search feels a bit too kitchen-sinky. I would expect the Communities page to have to deal with searches at some point, especially since I'm pretty sure sorting by different columns is in the pipeline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants