Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Cursor Pointers #31

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

CSS Cursor Pointers #31

wants to merge 6 commits into from

Conversation

ArztKlein
Copy link

Adds a hover cursor style attribute, which resolves #14.
When hovered, cursor will change to the cursor style, and when moved outside, will set the cursor to the initial style.

@Samathingamajig
Copy link
Contributor

You only changed ./library/p5.clickable.js, but you also need to change:

  • ./library/p5.clickable.min.js
  • ./example/lib/p5.clickable.js
  • ./example/lib/p5.clickable.min.js

@ArztKlein
Copy link
Author

Gotcha

@Samathingamajig
Copy link
Contributor

Looks like you missed ./example/lib/p5.clickable.min.js. Also make sure that ./example/lib/p5.clickable.js is given the exact same code from ./library/p5.clickable.js since if you just modified the lines you changed in the original commit, it might be out of date since the "example" code has been out of date for 10 months (if you already did this, great 👍)

@ArztKlein
Copy link
Author

There isn't a p5.clickable.min.j2 file there, should I create one? And I made lib/p5.clickable.js the same as ./library/p5.clickable.js, a few other things were missing.

@Samathingamajig
Copy link
Contributor

my bad, i saw p5.min.js and wasn't thinking correctly, thinking instead it was p5.clickable.min.js

@Samathingamajig
Copy link
Contributor

Currently, there's a bug (when I run it) where when you click on a button and keep the mouse button down, the cursor resets to the normal cursor.

@ArztKlein
Copy link
Author

Got it. I set the cursor at the wrong place

@Samathingamajig
Copy link
Contributor

Samathingamajig commented Jun 27, 2022

Looks good to me, except those changes also need to be reflected in the minified and library version

also /nit, while we're here plz make the fix mentioned in #15 to fix the global variable i since that was accidentally discarded due to the 2 instances of human-readable code for the library clashing

@ArztKlein
Copy link
Author

Is this what you mean?

Copy link
Contributor

@Samathingamajig Samathingamajig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but we need someone with write access. I'm not sure who has those privileges except for @Lartu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[enhancement] CSS Cursor Pointer Support
2 participants