-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS Cursor Pointers #31
base: master
Are you sure you want to change the base?
Conversation
You only changed
|
Gotcha |
Looks like you missed |
There isn't a p5.clickable.min.j2 file there, should I create one? And I made lib/p5.clickable.js the same as ./library/p5.clickable.js, a few other things were missing. |
my bad, i saw p5.min.js and wasn't thinking correctly, thinking instead it was |
Currently, there's a bug (when I run it) where when you click on a button and keep the mouse button down, the cursor resets to the normal cursor. |
Got it. I set the cursor at the wrong place |
Looks good to me, except those changes also need to be reflected in the minified and library version also /nit, while we're here plz make the fix mentioned in #15 to fix the global variable |
Is this what you mean? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, but we need someone with write access. I'm not sure who has those privileges except for @Lartu
Adds a hover cursor style attribute, which resolves #14.
When hovered, cursor will change to the cursor style, and when moved outside, will set the cursor to the initial style.