Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] visibleInModal not working anymore #5282

Closed
EmanueleCoppola opened this issue Aug 18, 2023 · 2 comments
Closed

[Bug] visibleInModal not working anymore #5282

EmanueleCoppola opened this issue Aug 18, 2023 · 2 comments
Assignees

Comments

@EmanueleCoppola
Copy link
Contributor

Bug report

The visibleInModal parameter is not working anymore with v6.
It seems that the modal is not there anymore.

https://backpackforlaravel.com/docs/6.x/crud-columns#choose-where-columns-are-visible

What I did

Just upgraded from v5 to v6.

What I expected to happen

I expected it to work like the previous version.

What I've already tried to fix it

--

Is it a bug in the latest version of Backpack?

After I run composer update backpack/crud the bug... is it still there? Yes

Backpack, Laravel, PHP, DB version

When I run php artisan backpack:version the output is:

### PHP VERSION:
PHP 8.1.2 (cli) (built: Jan 19 2022 10:18:23) (ZTS Visual C++ 2019 x64)
Copyright (c) The PHP Group
Zend Engine v4.1.2, Copyright (c) Zend Technologies

### LARAVEL VERSION:
10.19.0.0

### BACKPACK PACKAGE VERSIONS:
backpack/basset: 1.1.1
backpack/crud: 6.1.10
backpack/generators: v4.0.2
backpack/pro: 2.0.11
backpack/theme-tabler: 1.0.11
@pxpm
Copy link
Contributor

pxpm commented Aug 18, 2023

Hey @EmanueleCoppola thanks for the question.

Can you provide a little bit more info ? Maybe the column definition, and/or some screenshots of what's missing/broken ?

I've tested this with:

 $this->crud->addColumn([
  'name'  => 'text',
  'tab'   => 'Simple',
  'visibleInModal' => false,
]);

image

image

Let me know how it goes.

Cheers

@pxpm pxpm self-assigned this Aug 18, 2023
@pxpm pxpm added this to This week Aug 18, 2023
@pxpm pxpm moved this to In Progress in This week Aug 18, 2023
@pxpm
Copy link
Contributor

pxpm commented Aug 21, 2023

Closing this. We've found a bug while testing this #5284 that we are fixing in #5287 so thanks @EmanueleCoppola 🙏

Let me know if it still don't work for you, post some more details about your project so that I can help you better.
Overwritten views is a good starting point to check for.

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants