Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Editable Columns - Bulk Function Buttons not activating after editing #5175

Closed
srd2010 opened this issue Jul 4, 2023 · 3 comments
Closed
Assignees

Comments

@srd2010
Copy link
Contributor

srd2010 commented Jul 4, 2023

Bug report

What I did

Edited a row and then selected the row (checkbox) for a bulk function to be called.

What I expected to happen

Bulk Buttons should become active upon selection of at least one row (through checkbox)

What happened

Bulk Buttons do not become active.

What I've already tried to fix it

This can be solved by reloading the page, which is not user friendly.
Probably a matter of reapplying the trigger after editing.

Is it a bug in the latest version of Backpack?

No, it already happened in prior versions. Just waited with the report to see if it was fixed with the new release.

After I run composer update backpack/crud the bug... is it still there?

Yes

Backpack, Laravel, PHP, DB version

When I run php artisan backpack:version the output is:

PHP VERSION:

PHP 8.1.17 (cli) (built: Mar 16 2023 14:38:37) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.1.17, Copyright (c) Zend Technologies
with Zend OPcache v8.1.17, Copyright (c), by Zend Technologies
with Xdebug v3.2.0, Copyright (c) 2002-2022, by Derick Rethans

LARAVEL VERSION:

10.14.1.0

BACKPACK PACKAGE VERSIONS:

backpack/basset: 1.0.0
backpack/crud: 6.0.0
backpack/devtools: 2.0.2
backpack/editable-columns: 3.0.0
backpack/generators: v4.0.0
backpack/permissionmanager: 7.0.0
backpack/pro: 2.0.4
backpack/theme-coreuiv2: 1.1.0
backpack/theme-tabler: 1.0.1

@srd2010 srd2010 added the triage label Jul 4, 2023
@tabacitu tabacitu added the Possible Bug A bug that was reported but not confirmed yet. label Jul 11, 2023
@pxpm
Copy link
Contributor

pxpm commented Jul 14, 2023

Thanks for the report @srd2010

I can confirm the bug is present, and I already submitted a PR to fix it, should be merged and tagged soon 🙏

Sorry for the bad experience 😞

Cheers

@pxpm pxpm added Bug Priority: MUST and removed triage Possible Bug A bug that was reported but not confirmed yet. labels Jul 14, 2023
@pxpm pxpm assigned tabacitu and unassigned pxpm Jul 14, 2023
@pxpm pxpm moved this to Needs Testing, Review or Docs in This week Jul 14, 2023
@tabacitu tabacitu moved this to ⏳ Needs Testing / Review in Backpack v6.0.0 (🚀 on 1st of July 2023) Jul 20, 2023
@karandatwani92
Copy link
Contributor

@karandatwani92 karandatwani92 moved this from ⏳ Needs Testing / Review to ✅ Ready to Merge in Backpack v6.0.0 (🚀 on 1st of July 2023) Jul 23, 2023
@karandatwani92 karandatwani92 moved this from Needs Testing, Review or Docs to Ready to Merge in This week Jul 23, 2023
@pxpm pxpm closed this as completed Jul 24, 2023
@github-project-automation github-project-automation bot moved this from ✅ Ready to Merge to Done in Backpack v6.0.0 (🚀 on 1st of July 2023) Jul 24, 2023
@github-project-automation github-project-automation bot moved this from Ready to Merge to Done in This week Jul 24, 2023
@pxpm
Copy link
Contributor

pxpm commented Jul 24, 2023

Fixed, merged and tagged.

Thanks @srd2010 🙏 you should be able to get the fix with a composer update.

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

4 participants