Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalization off and some PDFs are zero on entire grid #6

Open
sschmidt23 opened this issue Aug 5, 2021 · 0 comments
Open

Normalization off and some PDFs are zero on entire grid #6

sschmidt23 opened this issue Aug 5, 2021 · 0 comments

Comments

@sschmidt23
Copy link
Collaborator

It appears that the output pdf normalization if off by a factor of the grid spacing. Also, for "bad" PDFs where none of the templates are a good fit and chi^2 is very large, the likelihood is zero everywhere. Having all zeros can be bad for normalization, we likely should replace this with a normalized uniform distribution (which is accurate, we have no idea what redshift is best, so all are equally likely)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant