Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsaved file shows "Untitled*" in title bar rather than filename #905

Closed
davidgerard opened this issue Jun 28, 2014 · 7 comments
Closed

Comments

@davidgerard
Copy link

When a file is saved and up-to-date, the title bar shows the name of the file, e.g. "ghost" for ghost.mmpz.

When I make a change to the song, it's now in unsaved condition. But rather than "ghost_", the title bar shows "Untitled_".

It should show the name of the file, with the star to indicate it's unsaved.

Ubuntu 14.04 amd64, LMMS compiled from latest git master.

@musikBear
Copy link

ooh master too? - i reported this for 1.0.2 some week ago, i now have a prc win 210614 for bughunt, and i havent seen that bug here ... not looked for either im afraid, i'l try to pay attention for just that, and return here if it occours.

@tresf
Copy link
Member

tresf commented Jul 5, 2014

The code calls this:

song.cpp#L1241

... which then calls this:

MainWindow.cpp#L555

I can't see anything obvious either function that's changed when compared to stable-1.1 (which I cannot reproduce this bug on) suggesting perhaps something in this code block is broken:

MainWindow.cpp#L558

But I couldn't find a change to song.cpp that would break this either...

Is there a chance that autosave is actually what's failing and inadvertently causing this?

-Tres

@musikBear
Copy link

fyi: i have autosave off
on 1.0.3 now - not seen it.

@Sti2nd
Copy link
Contributor

Sti2nd commented Jul 6, 2014

Happens with autosave on and off. To reproduce:

  1. Open a project with name.
  2. Edit a note. Make a new note in the Piano Roll.
  3. Play from the Song Editor. The name of the project is now "Untitled".

@Umcaruje
Copy link
Member

@davidgerard can you still reproduce this issue?

I haven't managed to do so on 1.1.3, Ubuntu 15.04

@davidgerard
Copy link
Author

Not seeing it in 1.1.3, and in fact I don't recall seeing it in 1.1.3. I think this might have been fixed along the way.

@Umcaruje
Copy link
Member

Awesome 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants