fix various AudioFileProcessor bugs #7533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by correctly setting m_from and m_to without them interfering with each other
see PR for before/after
this fixes the single point at the end of waveforms that sometimes shows up
execution seemed fine but my debugger started freaking out, and if gdb is telling me I got a negative-sized vector, I'd rather fix this issue than speculate "it's probably fine"
the data itself isn't reversed, so we have to account for that
|
eh, the other problems are just minor annoyances. If there's anything major I missed, feel free to tell me. |
michaelgregorius
requested changes
Oct 5, 2024
There was a problem hiding this comment.
@RiedleroD, just some small remarks. I like how you have presented the individual fixes with commit references in the description! 👍
michaelgregorius
approved these changes
Oct 6, 2024
mmeeaallyynn
pushed a commit
to mmeeaallyynn/lmms
that referenced
this pull request
Oct 27, 2024
* fix out-of-bounds crash in AudioFileProcessor by correctly setting m_from and m_to without them interfering with each other * fixed flattened wave caused by inaccurate math see PR for before/after * simply stop drawing AFP waveform when there's no more data this fixes the single point at the end of waveforms that sometimes shows up * fixed seemingly insignificant type confusion (?) execution seemed fine but my debugger started freaking out, and if gdb is telling me I got a negative-sized vector, I'd rather fix this issue than speculate "it's probably fine" * fixed data offset for AFP waveform vis the data itself isn't reversed, so we have to account for that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed crash by correctly setting m_from and m_to without them interfering with each other (bdfecb6)
crash is reproducable by fiddling with the endpoint and reversing every now and then, especially when zoomed in very far.
fixed flattened wave caused by inaccurate math (18b0e8c)
note: since this affects maxFrames, other less obvious inaccuracies are also fixed by this
Before/After Comparison
Reproducable by loading AcousticDrumset preset and looking at bassdrum_acoustic01.ogg.
stop drawing waveform after end of data d108c48
very subtle, but it kept bugging me, and it also helps with debugging the rest of this mess
Before/After Comparison
Reproducable by loading AcousticDrumset preset, setting bassdrum_acoustic01.ogg endpoint to 0.6, and fiddling with the volume knob.
correctly wrap drawing of waveform (2b7a3bf)
Before/After Comparison
Reproducable by loading AcousticDrumset preset, setting bassdrum_acoustic01.ogg endpoint to 0.5, and clicking on reverse.