Fix Bug with Continuous Autoscrolling when Smooth Scrolling is Enabled #7433
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a bug Gabrielxd195 pointed out, where enabling smooth scroll in the song editor causes the view to move at an uneven rate.
This is fixed by setting the scroll value directly through
m_leftRightScroll->setValue()
instead of usinganimateScroll()
.Also one thing I wanted to point out is that this means there will be no smooth scrolling for continuous autoscrolling whatsoever. So if the view needs to move a long distance to get to the current play position (like if you are editing the end of the song but then play it from the start), then it will do so instantly, without any smooth transition. That's probably fine for most people, but it means that the smooth scroll setting doesn't have any effect for continuous autoscrolling.
Related to #7396