Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add macOS arm64 builds #7285

Merged
merged 2 commits into from
May 31, 2024
Merged

Add macOS arm64 builds #7285

merged 2 commits into from
May 31, 2024

Conversation

tresf
Copy link
Member

@tresf tresf commented May 28, 2024

Adds macOS arm64 builds

Supersedes #7278

Related: LMMS/lmms.io@d5bc47f

image

https://lmms.io/download/pull-request/7285#mac

@tresf tresf mentioned this pull request May 28, 2024
Copy link
Member

@messmerd messmerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tresf
Copy link
Member Author

tresf commented May 28, 2024

LGTM

Thanks! Since this affects the nightly downloads, I'll kindly ask @DomClark or @PhysSong approve prior to merging.

Note, I've already added the new artifact suffix here: LMMS/lmms.io@d5bc47f.

There are some build warnings, specifically that our libraries provided by Homebrew are newer than our SDK version. If this becomes a problem in the future, we can bump the SDK here:

xcode: 14.3.1

@tresf
Copy link
Member Author

tresf commented May 30, 2024

All feedback addressed. :D

@tresf tresf requested a review from DomClark May 30, 2024 03:03
@tresf tresf merged commit a85c986 into LMMS:master May 31, 2024
10 checks passed
@tresf tresf deleted the macos-arm64 branch May 31, 2024 02:41
Rossmaxx pushed a commit to Rossmaxx/lmms that referenced this pull request Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants