Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Piano Roll doesn't highlight chord notes properly when vertically scaled. #6020

Open
Sofviic opened this issue May 17, 2021 · 1 comment
Open
Assignees
Labels

Comments

@Sofviic
Copy link

Sofviic commented May 17, 2021

Bug Summary

Piano Roll window's scale highlighting doesn't highlight within the outlines of the cells properly when vertically scaled.

Steps to reproduce

Open the Piano Roll, select a key & scale, and choose a vertical zoom other than 100%.

Expected behavior

For the scale highlighting to match the cell outlines.

Actual behavior

The highlighting doesn't match the cell outlines.

Screenshot

Scaling at 100%

PianoRollUnzoomed

Expected correct scaling at 200%

PianoRollZoomedCorrect

Actual Scaling at 200%

PianoRollZoomed

Affected LMMS versions

version of LMMS where the bug occurred was
Version 1.3.0-alpha.1.102+g89fc6c960 (win32/x86_64, Qt 5.9.8, GCC 7.3-win32 20180312).

As the vertical scaling isn't in version 1.2.2, this bug doesn't occur there.

@Sofviic Sofviic added the bug label May 17, 2021
@Veratil Veratil self-assigned this May 17, 2021
@Veratil
Copy link
Contributor

Veratil commented May 17, 2021

Thanks! I'll get this fixed up soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants