Muted tracks' activity indicator is out of sync with notes.

[softrabbit]

Bug Summary

Muted tracks' activity indicator is out of sync with notes.

Steps to reproduce

Add instruments to B&B editor, make them play the same rhythm and mute some.

Expected behavior

Muted channels' activity indicators should stay unlit, or if they're now intended to light up, they should do it in sync with what is playing.

Actual behavior

Muted channels light up, later than unmuted channels. This happens in both B&B and Song editors and can be observed across the editors, too.

Screenshot

Affected LMMS versions

Version 1.3.0-alpha.1.102+g89fc6c960 (win32/x86_64, Qt 5.9.8, GCC 7.3-win32 20180312).

[Spekular]

It almost looks like delay is caused by a ramp up in intensity on muted LEDs, could it be that the intensity animation is inverted/reversed?

EDIT: Perhaps the active color for muted indicators is the same as the off value. Switching QPalette::Highlight for something like a terrible pink would be a good way to debug this

lmms/src/gui/TrackView.cpp

Line 456 in 2f17c0d

QPalette::ColorRole role = muted ? QPalette::Highlight : QPalette::BrightText;

[enp2s0]

It looks like when a track is muted, it disables the "white flash" part of the animation, but not the "gray fade" part.

[enp2s0]

nevermind, that's incorrect. It seems like the offending code is in TrackView.cpp:

{
	FadeButton * indicator = getActivityIndicator();
	if (indicator) { setIndicatorMute(indicator, m_track->m_mutedModel.value()); }
}




void TrackView::setIndicatorMute(FadeButton* indicator, bool muted)
{
	QPalette::ColorRole role = muted ? QPalette::Highlight : QPalette::BrightText;
	indicator->setActiveColor(QApplication::palette().color(QPalette::Active, role));
}

when a track is muted, it overrides its fadebutton "activated" color, but not its fadebutton "note held" color. I'll try to get a PR fixing this.

[enp2s0]

Just created PR #6000 that should fix this.