Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSS: Functionality documentation #168

Closed
abhiramm7 opened this issue Jul 20, 2021 · 4 comments · Fixed by #180
Closed

JOSS: Functionality documentation #168

abhiramm7 opened this issue Jul 20, 2021 · 4 comments · Fixed by #180
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@abhiramm7
Copy link

Hi, I commend the authors on thorough documentation. In the JOSS paper submission, you mention that Abmarl integration with open ai gym and MultiAgentEnv. Having some documentation or a simple example on how users can interface with the two packages might be helpful.

@rusu24edward
Copy link
Collaborator

HI @abhiramm7

Thank you for your insightful review. Regarding integration with MultiAgentEnv and gym.Env, we do have this documented in the API spec here and here. Additionally, we the MultiCorridor tutorial and PredatorPrey tutorial show how to use the MultiAgentWrapper to treat the simulation as a MultiAgentEnv.

Does the documentation need to be clarified? Should I add another example using the GymWrapper?

@abhiramm7
Copy link
Author

I see that the MultiCorridor uses gym.spaces. I was under the impression that abmarl would be able to wrap around an existing open ai gym environment. I apologize if I am mis-interpreting it. I was thinking an example that uses an existing open ai gym environment with abmarl would be helpful to users.

@rusu24edward
Copy link
Collaborator

Thanks for the clarification! I agree, this would be helpful. I'll add a page on running Abmarl with already-existing gym environments.

@rusu24edward rusu24edward self-assigned this Jul 27, 2021
@rusu24edward rusu24edward added the documentation Improvements or additions to documentation label Jul 27, 2021
@rusu24edward
Copy link
Collaborator

@abhiramm7 Here is a brief demo for training a gym environment with abmarl: https://abmarl.readthedocs.io/en/latest/tutorials/gym.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants