Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Window Animation Repeated on Focus Change #945

Closed
topazrn opened this issue Aug 11, 2024 · 5 comments
Closed

[BUG]: Window Animation Repeated on Focus Change #945

topazrn opened this issue Aug 11, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@topazrn
Copy link

topazrn commented Aug 11, 2024

Describe the bug
Window animation will repeat (or more accurately stop and then resume from the position it was stopped but starting from the beginning of the animation curve) when window focus is changed. Either by moving the cursor out and into an animating window, or by letting an animating window passing through the cursor.

To Reproduce
Steps to reproduce the behavior:

  1. Trigger a window animation by opening, closing, or dragging an app window.
  2. Move cursor away from the window it was from.
  3. Move cursor back to the window it was from.
  4. See repeated animation.

Expected behavior
Changing mouse focus should not repeat window animation.

Screenshots and Videos

animation_bug.mp4

Operating System
OS Name: Microsoft Windows 10 Pro
OS Version: 10.0.19045 N/A Build 19045

komorebic check Output

No KOMOREBI_CONFIG_HOME detected, defaulting to C:\Users\Topaz

Looking for configuration files in C:\Users\Topaz

Found komorebi.json; this file can be passed to the start command with the --config flag

No ~/.config/whkdrc found; you may not be able to control komorebi with your keyboard
@topazrn topazrn added the bug Something isn't working label Aug 11, 2024
@LGUG2Z
Copy link
Owner

LGUG2Z commented Aug 11, 2024

May be already be fixed on this branch 🤔 #920

@topazrn
Copy link
Author

topazrn commented Aug 11, 2024

This branch right? https://github.com/thearturca/komorebi/tree/fix/cross-monitor-animation

I ran it but unfortunately the bug I reported still occurs.

@topazrn
Copy link
Author

topazrn commented Aug 11, 2024

Commenting this line fixed the issue but I don't know if it would introduce another issue.

WindowManagerEvent::FocusChange(_, window) => {
                // self.update_focused_workspace(self.mouse_follows_focus, false)?;

                let workspace = self.focused_workspace_mut()?;

@LGUG2Z
Copy link
Owner

LGUG2Z commented Aug 11, 2024

Do you have focus follows mouse enabled?

@topazrn
Copy link
Author

topazrn commented Aug 11, 2024

Yes I do have it enabled.

@LGUG2Z LGUG2Z closed this as completed Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants