Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring targetRotation setter api #454

Closed
ermolenkodev opened this issue Sep 21, 2022 · 0 comments
Closed

Refactoring targetRotation setter api #454

ermolenkodev opened this issue Sep 21, 2022 · 0 comments
Assignees
@ermolenkodev
Milestone
0.5

Comments

@ermolenkodev
Copy link
Collaborator

No description provided.

@ermolenkodev ermolenkodev added this to the 0.5 milestone Sep 21, 2022
@ermolenkodev ermolenkodev self-assigned this Sep 23, 2022
ermolenkodev added a commit to ermolenkodev/KotlinDL that referenced this issue Sep 26, 2022
@ermolenkodev
Remove targetRotation setter api (Kotlin#454)
77037e1 
* Add CameraXCompatibleModelType interface.

* Models from the android model hub can accept ImageProxy directly.

* Remove CameraXCompatibleModel interface as obsolete.

* Add utils to convert ImageProxy YUV_420_888 to Bitmap

* Add ConvertToBitmap preprocessing operation and update preprocessing DSL.
ermolenkodev added a commit to ermolenkodev/KotlinDL that referenced this issue Sep 29, 2022
@ermolenkodev
More convenient API for inference of ModelHub models with ImageProxy …
2b66664 
…input (Kotlin#454)

* Extend the ModelHub's models with an API that accepts ImageProxy as an input.

* Now user not required to set targetRotation property by hand

The rotation operation is quite expensive, so it's beneficial to make a rotation after resizing, although it makes API less intuitive.
ermolenkodev added a commit to ermolenkodev/KotlinDL that referenced this issue Sep 29, 2022
@ermolenkodev
More convenient API for inference of ModelHub models with ImageProxy …
ab71840 
…input (Kotlin#454)

* Extend the ModelHub's models with an API that accepts ImageProxy as an input.

* Now user not required to set targetRotation property by hand

The rotation operation is quite expensive, so it's beneficial to make a rotation after resizing, although it makes API less intuitive.
ermolenkodev added a commit to ermolenkodev/KotlinDL that referenced this issue Sep 29, 2022
@ermolenkodev
More convenient API for inference of ModelHub models with ImageProxy …
0d80a31 
…input (Kotlin#454)

* Extend the ModelHub's models with an API that accepts ImageProxy as an input.

* Now user not required to set targetRotation property by hand

The rotation operation is quite expensive, so it's beneficial to make a rotation after resizing, although it makes API less intuitive.
ermolenkodev added a commit to ermolenkodev/KotlinDL that referenced this issue Sep 29, 2022
@ermolenkodev @juliabeliaeva
Refactoring of extension functions with ImageProxy input (Kotlin#454)
10be87e 
* Introduce doWithRotation extension function to reduce code duplication

* Move extension functions to the base classes (e.g. SinglePoseDetectionModelBase instead SinglePoseDetectionModel)

Co-authored-by: Julia Beliaeva <[email protected]>
ermolenkodev added a commit that referenced this issue Sep 29, 2022
@ermolenkodev @juliabeliaeva
Remove targetRotation setter api (#454) (#456)
57e6465 
* More convenient API for inference of ModelHub models with ImageProxy input (#454)

* Extend the ModelHub's models with an API that accepts ImageProxy as an input.

* Now user not required to set targetRotation property by hand

The rotation operation is quite expensive, so it's beneficial to make a rotation after resizing, although it makes API less intuitive.

Fix wrong preprocessor for Mobilenetv1 in ModelHub

* Introduced in PR #459

* Refactoring of extension functions with ImageProxy input (#454)

* Introduce doWithRotation extension function to reduce code duplication

* Move extension functions to the base classes (e.g. SinglePoseDetectionModelBase instead SinglePoseDetectionModel)

Co-authored-by: Julia Beliaeva <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ermolenkodev ermolenkodev

Labels
None yet
Projects
None yet
Milestone
0.5
Development

No branches or pull requests
1 participant
@ermolenkodev