fix(entity-link): more robust url regex #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2c9f15f1beeb33b1b0fea299aaff0a2b528cf416.
mihai-peteu
changed the title
hfukada
reviewed
Nov 20, 2023
packages/entities/entities-shared/src/composables/useExternalLinkCreator.ts
Outdated
Show resolved
Hide resolved
adamdehaven
reviewed
Nov 21, 2023
| const urlRegex = /https?:\/\/(www\.)?[-a-zA-Z0-9@:%._\+~#=]{2,256}\.[a-z]{2,4}\b([-a-zA-Z0-9@:%_\+.~#?&//=]*)/g // eslint-disable-line no-useless-escape | ||
| // Test validity of generated URL; only allows `http` protocal if domain is `localhost` | ||
| /* eslint-disable-next-line no-useless-escape */ | ||
| const validUrlRegex = /^(https:\/\/(www\.)?([a-zA-Z0-9-]+\.){1,}[a-zA-Z]{2,}(:[0-9]+)?(\/[^\/]+)*)$|^(https|http):\/\/localhost(:[0-9]+)?(\/[^\/]+)*$/ |
There was a problem hiding this comment.
Would it make sense to add a unit test for this composable to test happy and bad paths?
There was a problem hiding this comment.
Good call - pushed a commit with a few more passing + failing cases
adamdehaven
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
URL regex should allow dev preview URLs / .tech / .com domains, but also
localhostwithhttpprotocol, followedPR Checklist