Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vault): update form fields for Azure vault #842

Merged
merged 1 commit into from
Oct 19, 2023
Merged

fix(vault): update form fields for Azure vault #842

merged 1 commit into from
Oct 19, 2023

Conversation

Leopoldthecoder
Copy link
Member

Summary

This PR updates Azure vault form fields according to the gateway schema.

PR Checklist

  • Naming & Structure: the files and package structure use the conventions outlined in the Creating a Package docs.
  • Tests pass: check the output of all package unit and/or component tests.
    • If this PR is the result of a bug, test coverage was added accordingly.
  • Functional: all changes do not break existing APIs, but if so, a BREAKING CHANGE commit is in place to bump the major version.
  • Conventional Commits all commits follow the conventional commit standards outlined in the main README.
  • Docs: includes a technically accurate README, and the docs have been updated accordingly based on the changes in this PR.

@Leopoldthecoder Leopoldthecoder requested review from a team as code owners October 17, 2023 09:11
@Leopoldthecoder Leopoldthecoder force-pushed the fix/azure-vault-fields branch 2 times, most recently from 81ed631 to 5297506 Compare October 18, 2023 02:24
sumimakito
sumimakito approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@sumimakito sumimakito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually tested in Kong Manager dev with Azure Key Vault enabled and LGTM

@Leopoldthecoder Leopoldthecoder merged commit 5314e8f into main Oct 19, 2023
@Leopoldthecoder Leopoldthecoder deleted the fix/azure-vault-fields branch October 19, 2023 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumimakito sumimakito sumimakito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Leopoldthecoder @sumimakito