Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct the entity lists permission prop type #747

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

nekolab
Copy link
Contributor

@nekolab nekolab commented Aug 31, 2023

All can*** props in the entity list component should accept the permission check functions in both the synchronous version and asynchronous version

Summary

PR Checklist

  • Naming & Structure: the files and package structure use the conventions outlined in the Creating a Package docs.
  • Tests pass: check the output of all package unit and/or component tests.
    • If this PR is the result of a bug, test coverage was added accordingly.
  • Functional: all changes do not break existing APIs, but if so, a BREAKING CHANGE commit is in place to bump the major version.
  • Conventional Commits all commits follow the conventional commit standards outlined in the main README.
  • Docs: includes a technically accurate README, and the docs have been updated accordingly based on the changes in this PR.

All `can***` props in entity list component should accept the
permission check functions in synchronous version
@nekolab nekolab changed the title fix: correct entity lists' permission prop type fix: correct the entity lists permission prop type Aug 31, 2023
Copy link
Member

@Leopoldthecoder Leopoldthecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nekolab nekolab marked this pull request as ready for review August 31, 2023 09:48
@nekolab nekolab requested review from a team as code owners August 31, 2023 09:48
@nekolab nekolab merged commit 965840a into main Aug 31, 2023
@nekolab nekolab deleted the fix/correct-entity-list-perm-props branch August 31, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants