-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pageheader): new component [khcp-7898] #610
Conversation
7d1f8b4
to
4bd3386
Compare
packages/core/app-layout/src/components/pageHeader/AppPageHeader.vue
Outdated
Show resolved
Hide resolved
29b8b06
to
c739ca3
Compare
packages/core/app-layout/src/components/pageHeader/AppPageHeader.vue
Outdated
Show resolved
Hide resolved
packages/core/app-layout/src/components/pageHeader/AppPageHeader.vue
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple things I noticed that seem like they need to be addressed in the UI:
-
The spacing between the title and the badge seems too close when compared to the Figma
-
This component doesn't appear to be ideally responsive below certain viewport sizes. Can you please add some media queries (using the
kui-breakpoint-*
tokens for media queries) and tweak the layout a bit so that the items properly stack on mobile? -
If the title text is too long, it send the action menu off of the page. I think we need to add a flex container around the title and action menu (or whatever the right-side content is called) so that the title can wrap to a new line and the action menu remains visible on the right
Co-authored-by: Adam DeHaven <[email protected]>
d1a30aa
to
fe95809
Compare
Fixed
Added mobile breakpoint styles Truncating the title in that scenario instead as agreed by design. Thanks for the help fixing this one @portikM ! @adamdehaven ready for re-review |
Summary
Add new
AppPageHeader
component for KHCP-7898.Also adds support to use new design tokens.
Figma: https://www.figma.com/file/8k70HMMdPj98APLaexYJyR/Header?type=design&node-id=11%3A7494&mode=dev
PR Checklist