Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(analytics): sanitize filenames [MA-1651] #366

Merged
merged 7 commits into from
May 1, 2023

Conversation

adamdehaven
Copy link
Member

Summary

Rename analytics filenames to vitals

PR Checklist

  • Naming & Structure: the files and package structure use the conventions outlined in the Creating a Package docs.
  • Tests pass: check the output of all package unit and/or component tests.
    • If this PR is the result of a bug, test coverage was added accordingly.
  • Functional: all changes do not break existing APIs, but if so, a BREAKING CHANGE commit is in place to bump the major version.
  • Conventional Commits all commits follow the conventional commit standards outlined in the main README.
  • Docs: includes a technically accurate README, and the docs have been updated accordingly based on the changes in this PR.

@adamdehaven adamdehaven self-assigned this May 1, 2023
@adamdehaven adamdehaven requested review from a team, jillztom and ValeryG as code owners May 1, 2023 15:01
ValeryG
ValeryG previously approved these changes May 1, 2023
@adamdehaven adamdehaven merged commit 8990dba into main May 1, 2023
@adamdehaven adamdehaven deleted the fix/rename-analytics-chunks branch May 1, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants