Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(entities): toolbar create button size #1605

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

Leopoldthecoder
Copy link
Member

@Leopoldthecoder Leopoldthecoder commented Sep 10, 2024

Summary

This PR uses useActionOutside to decide the size of the create entity button in the toolbar, so that:

  1. the create entity button size aligns with the learning hub icon in Gateway Manager
  2. the create entity button size aligns with the column toggle icon in Kong Manager

This PR also removes use-action-outside on EntityBaseTable because EntityBaseTable does not have this prop.

Gateway Manager Kong Manager
image image

Resources

@Leopoldthecoder Leopoldthecoder marked this pull request as ready for review September 10, 2024 08:53
@Leopoldthecoder Leopoldthecoder requested review from a team as code owners September 10, 2024 08:53
@Leopoldthecoder Leopoldthecoder merged commit a0aa37c into main Sep 10, 2024
18 checks passed
@Leopoldthecoder Leopoldthecoder deleted the fix/entity-create-button-size branch September 10, 2024 09:16
@Justineo
Copy link
Contributor

On a second thought, should we move the <Teleport> into EntityBaseTable and make the use-action-outside prop just work, instead of duplicating <Teleport> everywhere?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants