Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer dependency missing #16

Closed
silverbackdan opened this issue Mar 10, 2021 · 3 comments
Closed

Composer dependency missing #16

silverbackdan opened this issue Mar 10, 2021 · 3 comments

Comments

@silverbackdan
Copy link

I needed to add a dependency manually:
composer req --dev psr/http-factory

Otherwise the error appears:

Cannot determine controller argument for "Kocal\SymfonyMailerTesting\Controller\MailerController::reset()": the $responseFactory argument is type-hinted with the non-existent class or interface: "Psr\Http\Message\ResponseFactoryInterface". 

This should be added to composer dependencies.

Nice package, thank you!

@Kocal
Copy link
Owner

Kocal commented Mar 22, 2021

Hi, sorry for not seeing your issue before!

In the readme I suggest installing nyholm/psr7 when using the library with Cypress, but I suppose the controller auto-wiring will fails when no PSR-7 implementation is installed.

I suppose you are using Behat, so you don't really need PSR-7 implementation in fact.

I will see to remove controllers from container when no PSR-7 implementation is available. WDYT?

@silverbackdan
Copy link
Author

Hi @Kocal - no issue at all. That's right I'm implementing with Behat and have no need for the controllers so I think that sounds like a good solution to just remove that dependency requirement unless Cypress is being used.

@Kocal
Copy link
Owner

Kocal commented Mar 23, 2021

That will be fixed by #20

@Kocal Kocal closed this as completed in 9c828e6 Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants