New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use peerDependencies for npm package #528

Closed

crissdev opened this issue Jan 28, 2015 · 0 comments

Assignees

Labels

bug

Milestone

Member

crissdev commented Jan 28, 2015

The npm package may not decorate the appropriate instance of Knockout since it specifies Knockout in dependencies - as stated in #358.

The right approach is to use peerDependencies to specify the dependency on Knockout.

crissdev added the bug label

crissdev self-assigned this

crissdev added this to the 2.0.2 milestone

crissdev closed this as completed in

1a784bf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment