You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add file VTKSDKURLs.cmake listing URLs (https://vtk.org/files/wheel-sdks/) and SHAs of the relevant URLs intended to be re-packaged. Adapt from s5cmdUrls.cmake1 and consider matching the expected URL leveraging the variable Python3_SOABI2.
Update pyproject.toml setting wheel.install-dir = "vtk_wheel_sdk/content". Similar to how the content of the cmake package is installed when creating the corresponding wheel3
Adapt code from cmake-python-distributions/CMakeLists.txt4 to install the content of the existing vtk-sdk archive.
The files vtk-config.cmake and vtk-config-version.cmake aims to conveniently include the corresponding files installed in vtk_wheel_sdk/content/vtk-X.Y.Z.data/headers/cmake/vtk-config.cmake
Update pyproject.toml declaring the scikit-build-core "cmake.module" entry point5:
[project.entry-points."cmake.module"]
any = "vtk_wheel_sdk"
I think this is the first project to finish before doing anything else on SlicerLib
First issue is the SHA-256 files on https://vtk.org/files/wheel-sdks are not updated automatically (missing for vtk 9.4), this makes it unreliable.
Then I had issue with the version automatically fetched from git tags because any local modification broke the logic. I don't know we should do to address this too.
I think the easiest approach would be to ignore hash (but this may be a security issue), but keep automatically fetched version from git tags but postprocess it to extract the right version number ignoring local modification, dev0 etc
Re-package existing SDK
Add file
VTKSDKURLs.cmake
listing URLs (https://vtk.org/files/wheel-sdks/) and SHAs of the relevant URLs intended to be re-packaged. Adapt froms5cmdUrls.cmake
1 and consider matching the expected URL leveraging the variablePython3_SOABI
2.Update
pyproject.toml
settingwheel.install-dir = "vtk_wheel_sdk/content"
. Similar to how the content of the cmake package is installed when creating the corresponding wheel3Adapt code from
cmake-python-distributions/CMakeLists.txt
4 to install the content of the existing vtk-sdk archive.Entrypoint support
Add the following files to the project:
The files
vtk-config.cmake
andvtk-config-version.cmake
aims to conveniently include the corresponding files installed invtk_wheel_sdk/content/vtk-X.Y.Z.data/headers/cmake/vtk-config.cmake
Update
pyproject.toml
declaring the scikit-build-core "cmake.module" entry point5:Integration @jcfr
Footnotes
https://github.com/ImagingDataCommons/s5cmd-python-distributions/blob/main/s5cmdUrls.cmake ↩
https://cmake.org/cmake/help/latest/module/FindPython3.html ↩
https://github.com/scikit-build/cmake-python-distributions/blob/ab6a1365046ce83c6931c48d93c5c78112118c3f/pyproject.toml#L58 ↩
https://github.com/scikit-build/cmake-python-distributions/blob/560c40d038149556651fe8b01e66093c01aceb30/CMakeLists.txt#L422-L461 ↩
https://scikit-build-core.readthedocs.io/en/latest/cmakelists.html#finding-other-packages ↩
The text was updated successfully, but these errors were encountered: