Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue with token Authentication for ORTHANC #689

Closed
holakunle opened this issue Jan 21, 2025 · 6 comments · Fixed by #692
Closed

issue with token Authentication for ORTHANC #689

holakunle opened this issue Jan 21, 2025 · 6 comments · Fixed by #692
Assignees

Comments

@holakunle
Copy link

hello

I want to appreciate the entire kitware team. great jobs guys.
however, most orthanc users using the orthanc with authentication cannot use volview and here is the major reason

Volview is yet to support passing a token in the URL (eg …/index.html?token=my-token) and that this token is included in every HTTP request sent by Volview to Orthanc.

Is there something that can be done?

@PaulHax
Copy link
Collaborator

PaulHax commented Jan 21, 2025

That would be a great upgrade!

Do you know how the Orthanc plugin feeds VolView the file data?

Would you be intersted in helping with any of the other changes above?

@amazy
Copy link

amazy commented Jan 21, 2025

Hi @PaulHax

Currently, Orthanc opens VolView with this kind of url: http://localhost:8042/volview/index.html?names=[archive.zip]&urls=[../studies/b601fd03-c389b0a6-8ce8d63f-f907e550-431323e1/archive] so it means there is actually a single query from VolView to Orthanc !

In both StoneViewer and OHIF, when we pass &token=my-token in the url, they end up adding this HTTP header to all requests sent to Orthanc:
Authorization: Bearer my-token

As soon as you have a patch in Volview, I can take care of testing it with Orthanc !

@floryst floryst self-assigned this Jan 21, 2025
@floryst
Copy link
Collaborator

floryst commented Jan 21, 2025

This is actually on my near-term plate, so I will be tackling this.

@floryst
Copy link
Collaborator

floryst commented Feb 6, 2025

@amazy Support for token in the URL is now available in the main branch of VolView! Let me know if you have any issues or questions with it.

@PaulHax
Copy link
Collaborator

PaulHax commented Feb 19, 2025

@amazy Any luck with testing the token URL parameter?

@amazy
Copy link

amazy commented Feb 24, 2025

@floryst , @PaulHax I have tested it today and I confirm it works.

Thanks again !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants