Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rezisable interface and clickable knobs to enter value #5

Open
twarch opened this issue Apr 1, 2023 · 21 comments
Open

Rezisable interface and clickable knobs to enter value #5

twarch opened this issue Apr 1, 2023 · 21 comments

Comments

@twarch
Copy link

twarch commented Apr 1, 2023

Hey, just a few suggestions to enhance your plugin :)

First, many thanks for your work, it's very nice to have a free inflator in VST3 ! I use the RC version in Reaper but now I can use it in Studio One 👍

I think the interface could be better with a resizing option (lower right zipper?) and especially more sharpness on controls and fonts.
An option that could also be useful would be to be able to click the buttons to enter the value.

last point, I find that the oversampling under Reaper gives a better result than the oversampling integrated into the plugin, maybe a point to improve?

@Kiriki-liszt
Copy link
Owner

Thank you for checking out!

GUI related features are my weak points😢, but I would definitely learn how to 💪
Oversampling - I don't know exactly how REAPER does oversampling for each plugins, suspecting sth with like linear phase or so. Needs more research.

Thanks for such nice ideas, and I'll keep up any news with it in here!

@Kiriki-liszt
Copy link
Owner

GUI resizing is now done in branch v1.6.0rc1!
https://github.com/Kiriki-liszt/JS_Inflator_to_VST2_VST3/tree/v1.6.0rc1

@twarch
Copy link
Author

twarch commented Apr 6, 2023

Hey, very cool, thanks.

I'm trying to do something for the GUI, i'm not designer but i want to try for fun and if you want i can send it to you when it's finished ?

@twarch
Copy link
Author

twarch commented Apr 6, 2023

I try something closer to the original but with some different placements. This is my first try so I don't know if it's good, let me know :)

inflator design square alt2 3

@Kiriki-liszt
Copy link
Owner

Wow that is NEAT! Nice work!!
It's going to be more familiar to original Inflator users.
If you upload it to your Github repository or anywhere, I could link it in my repo and release page, and I would love to.
When it's finished, please leave your link here!

@twarch
Copy link
Author

twarch commented Apr 7, 2023

it still needs some improvements, but here is an almost finished result. I added an options panel but it may be more complicated to set up for you?
Otherwise it's a vector board made with Affinity Designer, will you be able to do something with it?

This is my last version:

inflator design square alt2 7 1-big
inflator design square alt2 7 1-big-opt

@twarch
Copy link
Author

twarch commented Apr 9, 2023

Last try:

inflator BLUE
inflator GREY

@Nitrate1984
Copy link

Omg, can't wait to see this GUI version, It's even better than the original inflator.

@Kiriki-liszt
Copy link
Owner

Nicely done! Love this Apple - Logic mordern feeling.
Thank you for your works!
Now it would be my turn to make this design working in plugin =)

Also, is there a way to insert a 'effect metering' as original do?
This feature is not implemented yet, but plans to do so.
And for my taste, I would like to have the latest version without side wooden panel and screws.

@twarch
Copy link
Author

twarch commented Apr 11, 2023

Thanks guys :)

This is a preview with fx metering and without screws and wood:

Inflator Design 1 2 1

So for the final version, I definitly remove screws and wood? You prefer grey or blue ? Orange or colored push buttons ? I can give you all of course.

And I think a good way to do this design is to do something like this instead of png for background? Not sure, I'm not a developer but like this you can change size and color more easily. on the other hand, I made a design with a size of 1400x1300 px which is more than enough even on a 4K screen.

@twarch
Copy link
Author

twarch commented Apr 11, 2023

I just reupload png files iin my fork with a note for coordinates and colors. Tell me if you need a background png or if you'll use another method (as describe in Juice link). If you need Background file, please let me know what elements are needed and I will do it. Thanks.

@Kiriki-liszt
Copy link
Owner

Kiriki-liszt commented Apr 13, 2023

New GUI is now on new_GUI branch and build file included!

FX meter kinda-maybe-working state.
Way to calculate Effect Meter is not clear yet.

Parameters are now able to entered.
Not sure how Waves made it work at double-clicking.
Checking their XMLs, it looks like a custom VSTGUI View with on_click, something like that.

Anyway, I'll work on this issue more.

@twarch
Copy link
Author

twarch commented Apr 13, 2023

hey, very cool to see the new GUI in action :)

I forgot to mention the font used: https://www.dafont.com/tt-octosquares.font looks really better.
And why you choose two different needle for the rotary knobs ? Looks better with the same color in my opinion :)

Another point which is not graphic is that the plugin opens with the effect at 100%, it would be preferable for it to open at zero.

@twarch
Copy link
Author

twarch commented Apr 13, 2023

I copy you the color and font size/type for all:

Inflator title: #8A8A8A TT Octosquares Trl Cnd (Blc)
preset nav: #6E6E6E
preset name: #BABABA TT Octosquares Trl (Lt)

Main blue: #6A9CC2
Main grey: #9A9A9A

middle panel blue: #5F8FB1
middle panel grey: #8B8B8B

Faders IN/OUT labels: #2E2E2E TT Octosquares Trl (Rg)
Faders dB values: #B4B4B4 TT Octosquares Trl Cnd (Lt)

Screen white (on) font: #CECFD0
Screen IN/FX/OUT Labels: TT Octosquares Trl (Md)
Screen OS label: TT Octosquares Trl (Lt)
Screen dark (off) font: #394955

Buttons On/Split/Clip: #626262 TT Octosquares Trl (Md)

Rotary values/Labels: #2E2E2E TT Octosquares Trl (Rg)

Colors and font size/type make a big difference in the design IMO

@Kiriki-liszt
Copy link
Owner

Kiriki-liszt commented Apr 13, 2023

For needles, white on yellow was hard to tell where it's at.

Initial Effect 100% is just my preference =)
I usually use Inflator at Bass or Guitar tone shaping stage, with input +3.0dB and effect fader high above 80%.
However, come to think of it, the original Inflator comes with 0%!
Now it starts at 0%.

Updated at new_GUI branch!

@twarch
Copy link
Author

twarch commented Apr 13, 2023

Yeah really nice, good job :)
And you're right, white on yellow is hard see, I'll try another color that match with yellow and red... I'm going to try other things, I have time I've been stuck in bed with lumbago for 15 days :(

EDIT; just to be picky, the x1/x2/x4/x8 in the rectangle don't have the same font size as the "OS", it's TT Octosquares Trl Cmd (Db), fit better with the rectangle. The IN/SPLIT/CLIP could be a little smaller to fit better too and to finish, the size and color off knob values are not good but I think it's a bit complicated to put the right font and color on it ?

@Kiriki-liszt
Copy link
Owner

Kiriki-liszt commented Apr 14, 2023

The font issues are caused because I use VSTGUI's text edit views.
These use system fonts that are avilable on every PC, like Arial.
For OS - there could be some way to choose from PNGs, but knob values will be tricky.
To use custom fonts in text edit I need to use 'package folder' system, not single .vst file.
Or embed .ttf and make temp file someware and load it there, etc.

+) Font color can be simply added. Will be changed on next build!

Latest build is now on 1.6.0rc branch, not new_GUI!
Let's keep rolling this thread.

@Kiriki-liszt
Copy link
Owner

last point, I find that the oversampling under Reaper gives a better result than the oversampling integrated into the plugin, maybe a point to improve?

The Oversampling from REAPER is now Implemeted, as 'Linear phase' mode!
It was r8brain-free-src - Sample rate converter designed by Aleksey Vaneev of Voxengo.
It took me whole weekend and few more to work it out, and now works great!

Latest build is now on 1.6.0rc1 branch.

@daxliniere
Copy link

Very cool. I think this should be renamed to OpenInflator. :)

@twarch
Copy link
Author

twarch commented Apr 26, 2023

Hey, I just upload new colors for rotary knobs and a more visible "needle".

Nice to see the linear phase OS ! Finally this plugin will be better than the original :)

Now I have to try to make the design with wood & screws works because I prefer it to the "simple" one.

@Kiriki-liszt
Copy link
Owner

Sorry for such late replies.
I was applying for Master’s Degree, and just got rejected =)
After that, I had some time for refresh, making music, doing live SR mixing in small club, etc...

I'll catch up on issues created, mostly about GUI, which is suspected by resizing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants