Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

array indices, node.jointName, and skin.jointNames #841

Closed
bghgary opened this issue Feb 15, 2017 · 2 comments
Closed

array indices, node.jointName, and skin.jointNames #841

bghgary opened this issue Feb 15, 2017 · 2 comments

Comments

@bghgary
Copy link
Contributor

bghgary commented Feb 15, 2017

I'm trying to convert BabylonJS's glTF loader to 2.0 and I'm running into an issue.

It looks like there is a conflict between using array indices and the way glTF references joints. Skins references joints by name via a jointName property on a node. But now that we are using array indices, I'm not sure how this should work. Is the intention to continue to reference by name? Should this become a joint node index that points to the node index? Or a separate joint index perhaps?

The schema currently uses integers for node.jointName and skin.jointNames which doesn't make much sense. Names are not integers :)

@javagl
Copy link
Contributor

javagl commented Feb 15, 2017

There are some pending changes from #723 (comment) that are already on the TODO list of #826 - I think that the core of your question is already addressed there.

@bghgary
Copy link
Contributor Author

bghgary commented Feb 15, 2017

Perfect, thanks! Closing since it's a dupe.

@bghgary bghgary closed this as completed Feb 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants