Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility of CESIUM_RTC and materials extensions #658

Closed
lexaknyazev opened this issue Jul 20, 2016 · 6 comments
Closed

Compatibility of CESIUM_RTC and materials extensions #658

lexaknyazev opened this issue Jul 20, 2016 · 6 comments

Comments

@lexaknyazev
Copy link
Member

If a material doesn't have any technique because of materials extension use, where should parameter with "CESIUM_RTC_MODELVIEW" semantic be located?

@pjcozzi
Copy link
Member

pjcozzi commented Aug 22, 2016

We haven't ran into this in practice, but we could, especially since Cesium supports both extensions. I feel like the solution will be when the materials extension is used to allow the material/technique to still list parameters to be merged with it. That could be messy though.

Perhaps table this until we have more cycles or there is community feedback to prioritize it, e.g., because it becomes a more broad problem with extension compatibility.

@lexaknyazev
Copy link
Member Author

The issue is bigger than just CESIUM_RTC, since any extension could define new parameter semantics and therefore be incompatible with materials extensions. Something to think of for future cycles.

@lexaknyazev
Copy link
Member Author

@pjcozzi Any updates on CESIUM_RTC with glTF 2.0?

@pjcozzi
Copy link
Member

pjcozzi commented Nov 23, 2018

@lilleyse have we ran into this yet?

@lilleyse
Copy link
Contributor

lilleyse commented Nov 23, 2018

I'm not sure if we have, but there is a workaround in the code that if a glTF 2.0 model has the CESIUM_RTC extension (without techniques) the internal model view matrix applies the CESIUM_RTC value.

@emackey
Copy link
Member

emackey commented Dec 23, 2020

Seems like this is OBE.

@emackey emackey closed this as completed Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants