-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require accessor min/max for POSITION? #593
Comments
Labeling as resolved. See fdf4337 in the |
Just to be clear, why are |
One more possibly worth mentioning constraint: |
See #617.
This is for simplicity and consistency. Early on, we received some glTF feedback that all properties should be required. We didn't agree as it can make things verbose; however, experience has shown that having some optional and some required properties has caused some implementation confusion for clients - which goes against one of our main goals: making glTF easy to implement consistency. So I think requiring |
I was curious because of opposite approach in #616 (diff). |
Ah, yes, I think we should make #616 (diff) apply to all attributes, not just @mlimper @lasalvavida what do you think?
|
It doesn't seem like a huge amount of work for implementers of glTF writers if we require them to also write min/max for other attributes, given that they would already provide this information for POSITION. |
Thanks for the input, @mlimper! @lexaknyazev are you good with this? The WEB3D_quantized_attributes spec will also go this direction. |
Consistency matters.
Validation will be simplier too. |
Thanks for the prompt response! 😄 |
Updated in #826 |
See CesiumGS/cesium#3925
The text was updated successfully, but these errors were encountered: