-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'expected render' screenshot of each model in readme table #301
Comments
Do you have a tool yet to generate the screenshots? (And I had to do some small adjustments to camera and light: bwasty/gltf-viewer@56604b0) |
Yes, @kcoley is working on a screenshot generator, but it will be specific for generating reference images based on BabylonJS. I'm assuming you are asking because you want to compare the results from your implementation against the reference. I discussed this a bit with the Khronos working group. I think it makes more sense for each implementation to do this work. We can possibly create a new repo that include some test harness code to help with web implementations. |
^One extra thought from my suggestion of adding URL of reference screenshot in the manifest, perhaps we also include the camera transform? Would make it much easier for other implementations to match. |
Hmm, interesting. Let's review this once we have the reference images. |
This is complete. |
The text was updated successfully, but these errors were encountered: