Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'expected render' screenshot of each model in readme table #301

Closed
2 tasks done
stevk opened this issue Dec 20, 2017 · 5 comments
Closed
2 tasks done

Add 'expected render' screenshot of each model in readme table #301

stevk opened this issue Dec 20, 2017 · 5 comments
Assignees
Milestone

Comments

@stevk
Copy link
Contributor

stevk commented Dec 20, 2017

  • Generate screenshots/gifs
  • Insert images into readme tables
@bwasty
Copy link

bwasty commented Feb 22, 2018

Do you have a tool yet to generate the screenshots?
I quickly wrote a script for my gltf-viewer: bghgary@5f6be5c
Here are the results: https://github.com/bwasty/glTF-Asset-Generator/tree/gltf-viewer (see subpages with reference images).
A few images are missing/wrong because some features are not implemented yet (primitive modes, TEX_COORD_1, alpha mode + cutoff ... bwasty/gltf-viewer#3)

(And I had to do some small adjustments to camera and light: bwasty/gltf-viewer@56604b0)

@bghgary
Copy link
Collaborator

bghgary commented Feb 22, 2018

Yes, @kcoley is working on a screenshot generator, but it will be specific for generating reference images based on BabylonJS.

I'm assuming you are asking because you want to compare the results from your implementation against the reference. I discussed this a bit with the Khronos working group. I think it makes more sense for each implementation to do this work. We can possibly create a new repo that include some test harness code to help with web implementations.

@donmccurdy
Copy link

^One extra thought from my suggestion of adding URL of reference screenshot in the manifest, perhaps we also include the camera transform? Would make it much easier for other implementations to match.

@bghgary
Copy link
Collaborator

bghgary commented Feb 23, 2018

perhaps we also include the camera transform?

Hmm, interesting. Let's review this once we have the reference images.

@kcoley kcoley added this to the v0.5 milestone Mar 5, 2018
@bghgary
Copy link
Collaborator

bghgary commented Mar 14, 2018

This is complete.

@bghgary bghgary closed this as completed Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants